Aryan SinghandClaude Opus 5
205e0a44b8
Three features and a typographic pass over everything. REVIEW. Picking a file and trusting it are different questions, so they now use different numbers. The existing rank decides which candidate to fetch and is right to weigh peer upload slots and queue length -- but none of that says anything about whether the file is the correct recording, and a fast peer must not be able to raise the confidence of a wrong match. So confidence() scores the filename alone: title 0.75, artist 0.25, album +0.05, and a variant tag you did not ask for multiplies by 0.8 AND caps below the auto threshold. Confidence gates the IMPORT, not the download. The transfer completes either way and the file waits in downloads, so approving is instant and rejecting is a delete. Holding the transfer instead would mean the peer is usually gone by the time anyone looks. The two cases it exists for: "02 Creep.flac" in an unsorted folder scores 0.75 -- title exactly right, artist simply absent, the commonest honest case there is -- and must be reviewed rather than binned. And "Creep (Live at Glastonbury)" scores 0.80 with BOTH artist and title perfect; the cap is what stops a live recording auto-filing over the studio version. Ask for "Creep (Acoustic)" and it auto-imports at 0.97, because then the variant is the request. DISCOVER. Related artists seeded from what you have actually imported, plus a recap of top artists, genres and decades. Built on muse's own request history, never on listening data: Navidrome owns play counts and history, and a second source of truth for those would disagree with the one you listen through. EMAIL. Optional, off unless MUSE_SMTP_HOST is set. Sends on import and on review-needed. smtplib is blocking so it runs off the event loop, and every failure is logged and swallowed -- a notification is never worth failing an import over. Google accounts need no configuration, since the identity is an address. Each user owns their own setting under Settings, deliberately not an admin route: an address you cannot change yourself is someone else's chore. DESIGN. A real type scale (display/title/headline/body/callout/caption) whose tracking tightens as size grows, which is the single biggest tell of typography nobody set. Specular top edges on glass surfaces -- blur alone reads as a grey rectangle. A two-part elevation scale, contact shadow plus soft light. Semantic colours are now per-theme: the amber tuned for the dark background failed contrast outright on white, which was exactly the text a reviewer most needs to read. The tab underline became a sliding pill so the eye tracks one object, and Review only appears when something is actually waiting. Add tests/test_matching.py: 13 assertions on the confidence bands rather than the exact scores. 90 tests pass across the three suites. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
78 lines
3.0 KiB
Python
78 lines
3.0 KiB
Python
"""Confidence calibration. These are the thresholds that decide whether a
|
|
download lands in the library untouched or waits for a human, so the bands
|
|
matter more than the exact numbers -- assert the band, not the score."""
|
|
import os, sys
|
|
|
|
sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
|
|
os.environ.setdefault("MUSE_AUTH", "off")
|
|
os.environ.setdefault("MUSE_DB", "dev/matching.db")
|
|
import app # noqa: E402
|
|
|
|
CASES = [
|
|
# well-organised shares: artist and album in the path
|
|
(r"@@music\Radiohead\Pablo Honey\02 - Creep.flac", "Radiohead", "Creep",
|
|
"Pablo Honey", "auto"),
|
|
(r"Kendrick Lamar\good kid\06 - Money Trees.flac", "Kendrick Lamar",
|
|
"Money Trees", "good kid, m.A.A.d city", "auto"),
|
|
(r"Music\R\Radiohead - Creep.mp3", "Radiohead", "Creep", None, "auto"),
|
|
(r"x\Tame Impala - The Less I Know The Better.flac", "Tame Impala",
|
|
"The Less I Know The Better", None, "auto"),
|
|
|
|
# right song, but something is missing or off -- a human should look
|
|
(r"shared\02 Creep.flac", "Radiohead", "Creep", "Pablo Honey", "review"),
|
|
(r"Live\Radiohead - Creep (Live at Glastonbury 1997).mp3", "Radiohead",
|
|
"Creep", None, "review"),
|
|
(r"Radiohead\Creep (Remix).mp3", "Radiohead", "Creep", None, "review"),
|
|
|
|
# wrong song, or too little to tell
|
|
(r"covers\Creep (Acoustic Cover).mp3", "Radiohead", "Creep", None, "low"),
|
|
(r"Various\Karma Police.flac", "Radiohead", "Creep", None, "low"),
|
|
(r"stuff\track01.mp3", "Radiohead", "Creep", None, "low"),
|
|
(r"Nirvana\Nevermind\01 - Smells Like Teen Spirit.flac", "Radiohead",
|
|
"Creep", None, "low"),
|
|
]
|
|
|
|
|
|
def band(c: float) -> str:
|
|
if c >= app.AUTO_CONFIDENCE:
|
|
return "auto"
|
|
return "review" if c >= app.REVIEW_CONFIDENCE else "low"
|
|
|
|
|
|
def main() -> int:
|
|
bad = 0
|
|
for fn, artist, title, album, want in CASES:
|
|
c, why = app.confidence(fn, artist, title, album)
|
|
got = band(c)
|
|
if got != want:
|
|
bad += 1
|
|
print(f" FAIL {got:<6} (want {want:<6}) {c:.2f} {fn}")
|
|
print(f" {'; '.join(why)}")
|
|
else:
|
|
print(f" PASS {got:<6} {c:.2f} {fn}")
|
|
|
|
# A variant tag must never auto-import, however perfect the rest is.
|
|
c, _ = app.confidence(r"Radiohead\Pablo Honey\Creep (Live).flac",
|
|
"Radiohead", "Creep", "Pablo Honey")
|
|
if c >= app.AUTO_CONFIDENCE:
|
|
bad += 1
|
|
print(f" FAIL a live version auto-imported at {c:.2f}")
|
|
else:
|
|
print(f" PASS live version capped below auto ({c:.2f})")
|
|
|
|
# ...unless the variant is what was asked for.
|
|
c, _ = app.confidence(r"Radiohead\Creep (Acoustic).mp3", "Radiohead",
|
|
"Creep (Acoustic)", None)
|
|
if c < app.AUTO_CONFIDENCE:
|
|
bad += 1
|
|
print(f" FAIL requested acoustic version held at {c:.2f}")
|
|
else:
|
|
print(f" PASS requested acoustic version auto-imports ({c:.2f})")
|
|
|
|
print(f"\n{len(CASES) + 2 - bad} passed, {bad} failed")
|
|
return 1 if bad else 0
|
|
|
|
|
|
if __name__ == "__main__":
|
|
sys.exit(main())
|